BUG: Clarify KeyError for missing groups in GroupBy.get_group #63868
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I’ve closed the previous PR and opened a new one with a clean history. |
Member
Just for any future PRs, pandas squash-merges all PRs. The history within a PR does not matter. It would be good to not close and reopen unless necessary (e.g. a merge went bad). |
Author
|
@rhshadrach Thanks for clarifying, that makes sense. I’ll keep this in mind for future PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Update the error raised by GroupBy.get_group when a requested group
key is not found.
*Replace the previous bare KeyError(name) with a message that clearly
indicates the missing group.
*Add a regression test for this case.